diff options
| author | Rodrigo Arias Mallo <rodarima@gmail.com> | 2025-09-28 20:26:15 +0200 |
|---|---|---|
| committer | Rodrigo <rodarima@gmail.com> | 2025-09-28 23:10:55 +0200 |
| commit | fb510ea86be5ceb9e91573890242581fdbd77ad8 (patch) | |
| tree | d819fe40683592008d136727f5a0b03e48dc1164 /289 | |
Diffstat (limited to '289')
| -rw-r--r-- | 289/index.md | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/289/index.md b/289/index.md new file mode 100644 index 0000000..7da3e9f --- /dev/null +++ b/289/index.md @@ -0,0 +1,32 @@ +Title: Use git commit in version if built from git +Author: rodarima +Created: Tue, 22 Oct 2024 18:23:30 +0000 +State: closed + +Attempts to fix #288 + +I see at least one **big** problem: + +``` +$ git clone ... && cd dillo +$ ./autogen.sh # this will populate the version +$ mkdir build && cd build +$ ../configure && make # Okay, not we build dillo with the correct version +$ cd .. +$ $EDITOR src/... +$ git checkout -b foobar +$ git add ... +$ git commit -m foo +$ cd build +$ ../configure # <--- now we are placing the wrong version in dillo, as it was not updated in configure +``` + +So if I forget to run `./autogen.sh` again I get a fully working dillo binary with the wrong version. + +This should run at configure time, not when running autoconf. + +--%-- +From: rodarima +Date: Mon, 09 Dec 2024 19:05:29 +0000 + +Closing in favor of #318
\ No newline at end of file |