blob: 7da3e9f36925f60e4a7b6bac84ad7e6c4b03ee56 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
|
Title: Use git commit in version if built from git
Author: rodarima
Created: Tue, 22 Oct 2024 18:23:30 +0000
State: closed
Attempts to fix #288
I see at least one **big** problem:
```
$ git clone ... && cd dillo
$ ./autogen.sh # this will populate the version
$ mkdir build && cd build
$ ../configure && make # Okay, not we build dillo with the correct version
$ cd ..
$ $EDITOR src/...
$ git checkout -b foobar
$ git add ...
$ git commit -m foo
$ cd build
$ ../configure # <--- now we are placing the wrong version in dillo, as it was not updated in configure
```
So if I forget to run `./autogen.sh` again I get a fully working dillo binary with the wrong version.
This should run at configure time, not when running autoconf.
--%--
From: rodarima
Date: Mon, 09 Dec 2024 19:05:29 +0000
Closing in favor of #318
|
