Don't allocate gif->linebuf so soon.

Occasionally, linebuf leaks have appeared in Jeremy's valgrind logs.

linebuf is used in Gif_literal() and Gif_sequence(). They are called
by Gif_process_code(), which is called by Gif_decode(). In
Gif_process_bytes(), you have to be in state 3 to call it.

linebuf is allocated inside Gif_do_img_desc(), which is called by
GIF_Block(). In Gif_process_bytes(), you have to be in state 2 to
call it.

After the allocation, there are a couple of cases where the code
can return while still in state 2, which would mean coming back to
Gif_do_img_desc() later and leaking the linebuf by allocating another.

Jeremy has kindly run on this patch for ten days or so without incident.

0 files changed, 0 insertions, 0 deletions