aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcorvid <corvid@lavabit.com>2011-10-11 18:38:05 +0000
committercorvid <corvid@lavabit.com>2011-10-11 18:38:05 +0000
commitc0f3c0d960fba0e31d80ec26e0c9576e52e12bf2 (patch)
treeefbd357191298e1bc3f245977f1adca594a2d516
parent9e3a1b6c974580fe72462cc79a5e25836f891649 (diff)
digest auth: in Authorization header, quote digest-uri-value
found by furaisanjin. http://www.rfc-editor.org/errata_search.php?rfc=2617 has an entry showing that this should be done. Now, the RFC was done in 1999, and the error was reported in 2010 and verified in 2011, so we're lucky with our timing, but isn't it surprising how slow of a process it is to clean out the corners like this in important specifications?
-rw-r--r--src/digest.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/digest.c b/src/digest.c
index f09201a2..da1e66da 100644
--- a/src/digest.c
+++ b/src/digest.c
@@ -176,7 +176,7 @@ char *a_Digest_authorization_hdr(AuthRealm_t *realm, const DilloUrl *url,
Digest_Dstr_append_token_value(result, 0, "username", realm->username, 1);
Digest_Dstr_append_token_value(result, 1, "realm", realm->name, 1);
Digest_Dstr_append_token_value(result, 1, "nonce", realm->nonce, 1);
- Digest_Dstr_append_token_value(result, 1, "uri", digest_uri, 0);
+ Digest_Dstr_append_token_value(result, 1, "uri", digest_uri, 1);
if (realm->algorithm != ALGORITHMNOTSET) {
Digest_Dstr_append_token_value(result, 1, "algorithm",
ALGORITHM2STR[realm->algorithm], 0);