blob: 12cb25c2bd2376264ec5431363ccd1e82315220c (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
|
Title: Preserve aspect ratio of images
Author: rodarima
Created: Mon, 12 Aug 2024 22:01:47 +0000
State: closed
A common problem for images is that only one dimension is given {height,width}
or that a range is set by {min,max}-{height,width}. Previously, the original
size of the image was used to compute the aspect ratio and then fill the missing
dimension.
But the procedure requires more steps to fulfill all constraints. This PR tries
to cover all posible cases of constrained images while preserving the aspect
ratio. When is not posible, the aspect ratio is distorted to fit the size
constraints.
### TODO
- [x] Test several combinations of padding and margins to check we continue to
compute the image size correctly. -> Tested manually, but we may want to add more render tests to the suite.
- [x] Test floating images and cases where they might not have a parent.
- [x] Check the problem with gigantic images is not introduced by this PR.
---
<details>
<summary>How it looks</summary>
Before:
After:
</details>
--%--
From: rodarima
Date: Thu, 17 Oct 2024 18:47:53 +0000
Testing with float images improves when compared with the previous behavior, but continues to show problems when computing the parent requisition. I think we can leave this for a future PR, to avoid stalling this one forever.
|
