Age | Commit message (Collapse) | Author |
|
clang complains about this
|
|
first brought up
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2013-January/009809.html
|
|
On the whole, this makes things easier to deal with.
|
|
|
|
Discussion:
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2012-December/009604.html
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2012-December/009609.html
Fl_Tree didn't handle the 18000-item list in
https://bugzilla.redhat.com/query.cgi?format=advanced so well,
plus it's relatively heavy, plus we've found bugs in it on occasion
because it's newer than Fl_Browser. Fl_Browser is naturally
closer to what we use than Fl_Tree is in its ordinary default
usage.
Why didn't I use Fl_Browser initially when going to fltk-1.3?
Documentation made it sound like fltk1 and fltk2's browsers were
quite different despite having the same name (I think the APIs
were rather dissimilar, although I don't feel it's worth my time
to verify that right now), and I believe I had the impression that
Fl_Browser was going to be too limited in some ways.
|
|
The search engine option menu was activable with keyborad (Down key). Made
this work again. Also made FORM option menus activable with Down key.
|
|
Alexander asked for this a while back to make the behaviour more
consistent -- it seems that ctrl tends to mean "a word at a time".
|
|
The other day, I saw how it uses it for backspace, and I'd left it partly
because it reminds me of older unixness, but then I was reminded how ctrl-h
is our default to go to the home page, so...
|
|
|
|
|
|
In bug #1110, Alexander pointed out that it grabs ^L instead of letting it
trigger focusing of the location bar.
I note that the html5 draft currently insists that ^J and ^M not be permitted
to find their way into the control's value. I imagine they could still be
pasted in, but *shrugs*.
|
|
|
|
|
|
Broken in b21a663f7de4 when fixing the coordinates for mouse click.
|
|
I think I have it just right now.
|
|
|
|
...and do list selection through tree to get draw() calls. Selection through
the item just toggles a flag, which makes sense, but I didn't particularly
expect the distinction.
|
|
|
|
This had been discussed a bit a few years ago. At the time, the html4 spec's
idea was that you probably should require one but that implementations varied
on the details.
These days, firefox doesn't, and html5 mostly tells you not to (and is clear
that you can deselect the only selected one). (The world's biggest document,
practically a browser written in english at the instruction level, and it
still has many cases that aren't considered and spelled out carefully at this
point.)
|
|
|
|
|
|
|
|
|
|
|
|
Jump to the next menuitem whose label starts with the pressed key.
If there's more than one item starting with the same letter, go to
the next one, then wrap.
This works when the OPTION menu is focused, not displayed.
FLTK has a hacked way of handling menus which will change in
FLTK3 [1] [2].
Making it work when the menu is displayed would involve copying a lot of
code and dealing with hackish FLTK internals, which is not stable. It
seems wiser to use this workaround until FLTK3 solves the problem.
[1] http://fltk.org/newsgroups.php?s1060+gfltk.general+v1070+T0+Qmenu+scrolling
[2] http://fltk.org/newsgroups.php?s1080+gfltk.general+v1087+T0+Qmenu+scrolling
|
|
|
|
1. coordinates weren't relative to widget.
2. margin/border/padding weren't taken into account.
|
|
Topic brought up by Alexander recently. In FLTK2, Enter and Space would
both trigger buttons. In 1.3, only Space does it. I asked the FLTK guys
about this, and I learned that Space to trigger buttons is actually
old-school X behaviour that I somehow never became aware of.
|
|
|
|
|
|
|
|
Pretty easy workaround, yes? :)
|
|
|
|
In fltk-1.3, it doesn't draw inside labels for Fl_Inputs, and it
wasn't very nice anyway. Here I move them to the left.
Johannes took a look at this change:
"The only issue I could think of is that the additional
draw_outside_label() would cause excessive redraws for
some reason. But I didn't see anything like that during short
testing here."
|
|
|
|
|
|
|
|
I would still like Enter to work as well, but I haven't looked into
whether that would be nicely trivial -- and I still don't know whether
I'm the only user who expects Enter to trigger buttons.
|
|
Haven't found any need for it with 1.3.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
There was some discussion of how to do this last month in fltk-dev
http://fltk.org/newsgroups.php?s10630+gfltk.development+v10640+T0
|
|
|
|
|
|
- The background for the radio/check button likes to be white, so I'm
leaving selection_color() as black.
- OptionMenu, I don't like what background color we tend to get for a
selected item while the menu's up, but you can always tell what's
current by the box, anyway.
- ListMenu, that will wait until some Fl_Tree changes are made, which it
sounds like will happen very shortly.
|
|
|