diff options
author | Sebastian Geerken <devnull@localhost> | 2016-01-02 11:29:52 +0100 |
---|---|---|
committer | Sebastian Geerken <devnull@localhost> | 2016-01-02 11:29:52 +0100 |
commit | e11d08ddc34e4182673bab6af6c573f6c4a40fe6 (patch) | |
tree | 68fb94e4e2663305e759824d0106f1263a20794d | |
parent | 722db0f57178e7ce0d0292d8ffe2f7adbbb7b5aa (diff) |
SRDOP: Updated documentation.
-rw-r--r-- | devdoc/dw-out-of-flow-floats.doc | 12 | ||||
-rw-r--r-- | devdoc/dw-out-of-flow-positioned.doc | 5 | ||||
-rw-r--r-- | devdoc/dw-size-request-pos.doc | 33 | ||||
-rw-r--r-- | dw/core.hh | 2 |
4 files changed, 32 insertions, 20 deletions
diff --git a/devdoc/dw-out-of-flow-floats.doc b/devdoc/dw-out-of-flow-floats.doc index 6d0777fc..2f92a5c6 100644 --- a/devdoc/dw-out-of-flow-floats.doc +++ b/devdoc/dw-out-of-flow-floats.doc @@ -131,13 +131,21 @@ Instead, this approach is focussed: textblock of this kind then reard the floats in detail, to insert empty lines when needed? -**Real-world cases:** *Overflow:hidden* is set for headings in +<b>Real-world cases:</b> *Overflow:hidden* is set for headings in Wikipedia, and so this case occurs when there is a float (thumb image) before a heading. See e. g. <a href="http://de.wikipedia.org/wiki/Emmerich_am_Rhein#Ans.C3.A4ssige_Unternehmen">this page</a> and scroll a bit up; the company logos should be right of this section. -**Priority:** Since this is not a regression, compared to not +<b>Priority:</b> Since this is not a regression, compared to not supporting floats at all, a fix is not urgent for a new release. +Resizing +-------- +Has the case that a float changes its position to be regarded? Probably yes, but +cases where no other mechanisms come into play are rather unlikely. + +<b>Priority:</b> If this plays a role, this means a regression compared to not +supporting floats at all. + */ diff --git a/devdoc/dw-out-of-flow-positioned.doc b/devdoc/dw-out-of-flow-positioned.doc index 9269c49d..4f49b411 100644 --- a/devdoc/dw-out-of-flow-positioned.doc +++ b/devdoc/dw-out-of-flow-positioned.doc @@ -1,6 +1,9 @@ /** \page dw-out-of-flow-positioned Handling Elements Out Of Flow: Positioned Elements -TODO +<div style="border: 2px solid #ffff00; margin: 1em 0; padding: 0.5em + 1em; background-color: #ffffe0">Positioned elements have been + deactivated, during the development of \ref dw-size-request-pos, to + focus on floats. See dw::core::IMPL_POS in file dw/core.hh.</div> Miscellaneous notes diff --git a/devdoc/dw-size-request-pos.doc b/devdoc/dw-size-request-pos.doc index fddf76c8..88e51097 100644 --- a/devdoc/dw-size-request-pos.doc +++ b/devdoc/dw-size-request-pos.doc @@ -6,9 +6,6 @@ dw-widget-sizes, \ref dw-grows, and **Size requisitions depending on positions** (this document).</div> -<div style="border: 2px solid #ff4040; margin: 1em 0; - padding: 0.5em 1em; background-color: #fff0f0"><b>Info:</b> - May not be up to date, needs a review.</div> Motivation ========== @@ -99,18 +96,21 @@ Currently, the size of a widget has to be recalculated, when 1. it has called dw::core::Widget::queueResize, or 2. the size of a child widget has to be recalculated. -Since for this new approach, the size does not only depend on the size -of the children, the second condition must be modified. However, -regarding changes of the position is not sufficient. Consider this -example, where a float size changes as soon as the image is loaded: +Since for this new approach, the size does not only depend on the size of the +children, the second condition must be modified. See beginning of +dw::core::Widget::sizeRequest. -\image html dw-size-request-pos-01.png +Regarding changes of the position is not sufficient. Consider this example, +where a float size changes as soon as the image is loaded: -The second paragraph ("A longer paragraph" ...) stays at the same -position, both absolute and relative to the float container, but has -to be rewrapped because of the float. +\image html dw-size-request-pos-01.png -(TODO: A detailed design is yet to de developed.) +The second paragraph ("A longer paragraph" ...) stays at the same position, both +absolute and relative to the float container, but has to be rewrapped because of +the float. Instead, this is handled by dw::oof::OutOfFlowMgr::markSizeChange +(and likewise dw::oof::OutOfFlowMgr::markExtremesChange), which is called by the +implementation of `markSizeChange` (or `markExtremesChange`, respectively) of +the OOF container. (See also the end of the comment of dw::oof::OOFAwareWidget.) Plan @@ -119,8 +119,7 @@ Plan 1. General design (dw::core::Widget::sizeRequestReference, changes to dw::core::Widget::sizeRequest). Completed. -2. Implementation for dw::Textblock. Completed. (**TODO:** Check how the return - values of `get*Border` are used.) +2. Implementation for dw::Textblock. Completed. 3. Change interface of dw::oof::OutOfFlowMgr (this affects mostly only comments). Completed. @@ -139,10 +138,12 @@ Plan <b>Attention:</b> After this step, and before completing the next steps, the code is inconsistend and so incorrect. -5. Implement step 3 for floats (affects dw::oof::OOFFloatsMgr). **IN WORK.** +5. Implement step 3 for floats (affects dw::oof::OOFFloatsMgr). **MOSTLY + COMPLETED.** 6. Implement step 3 for positioned elements (affects only - dw::oof::OOFPositionedMgr). **INCOMPLETE.** + dw::oof::OOFPositionedMgr). **INCOMPLETE.** (But positioned elements are + currently deactivated.) Issues @@ -12,7 +12,7 @@ */ namespace dw { -// Used (temporally) for code related to positioned elements. +/** Used (temporally) for code related to positioned elements. */ enum { IMPL_POS = false }; /** |