Eliminated a pack of 22 compiler warnings (gcc-4.6.1 amd64)

11 files changed, 31 insertions, 49 deletions

diff --git a/dpi/downloads.cc b/dpi/downloads.cc
index 47ef4e0d..46e847ff 100644
--- a/dpi/downloads.cc
+++ b/dpi/downloads.cc
@@ -599,13 +599,11 @@ static void read_log_cb(int fd_in, void *data)
    const int BufLen = 4096;
    char Buf[BufLen];
    ssize_t st;
-   int ret = -1;
 
    do {
       st = read(fd_in, Buf, BufLen);
       if (st < 0) {
          if (errno == EAGAIN) {
-            ret = 1;
             break;
          }
          perror("read, ");
@@ -614,7 +612,6 @@ static void read_log_cb(int fd_in, void *data)
          close(fd_in);
          Fl::remove_fd(fd_in, 1);
          dl_item->log_done(1);
-         ret = 0;
          break;
       } else {
          dl_item->log_text_add(Buf, st);
diff --git a/dpid/misc_new.c b/dpid/misc_new.c
index 7f963aed..8c07a4eb 100644
--- a/dpid/misc_new.c
+++ b/dpid/misc_new.c
@@ -71,14 +71,12 @@ Dstr *a_Misc_rdtag(int socket)
  */
 char *a_Misc_readtag(int sock)
 {
-   char *tag, c, buf[10];
-   size_t buflen, i;
+   char *tag, c;
+   size_t i;
    size_t taglen = 0, tagmem = 10;
    ssize_t rdln = 1;
 
    tag = NULL;
-   buf[0] = '\0';
-   buflen = sizeof(buf) / sizeof(buf[0]);
    // new start
    tag = (char *) dMalloc(tagmem + 1);
    for (i = 0; (rdln = read(sock, &c, 1)) != 0; i++) {
diff --git a/dpip/dpip.c b/dpip/dpip.c
index a5517784..170e4a88 100644
--- a/dpip/dpip.c
+++ b/dpip/dpip.c
@@ -214,11 +214,13 @@ int a_Dpip_check_auth(const char *auth_tag)
       MSG_ERR("[a_Dpip_check_auth] empty file: %s\n", fname);
    } else {
       port = strtol(rcline, &tail, 10);
-      for (i = 0; *tail && isxdigit(tail[i+1]); ++i)
-         SharedSecret[i] = tail[i+1];
-      SharedSecret[i] = 0;
-      if (strcmp(msg, SharedSecret) == 0)
-         ret = 1;
+      if (tail && port != 0) {
+         for (i = 0; *tail && isxdigit(tail[i+1]); ++i)
+            SharedSecret[i] = tail[i+1];
+         SharedSecret[i] = 0;
+         if (strcmp(msg, SharedSecret) == 0)
+            ret = 1;
+      }
    }
    if (In)
       fclose(In);
@@ -376,7 +378,7 @@ int a_Dpip_dsh_write_str(Dsh *dsh, int flush, const char *str)
 static void Dpip_dsh_read(Dsh *dsh, int blocking)
 {
    char buf[RBUF_SZ];
-   int req_mode, old_flags = 0, st, ret = -3, nb = !blocking;
+   int req_mode, old_flags = 0, st, nb = !blocking;
 
    dReturn_if (dsh->status == DPIP_ERROR || dsh->status == DPIP_EOF);
 
@@ -395,7 +397,6 @@ static void Dpip_dsh_read(Dsh *dsh, int blocking)
             continue;
          } else if (errno == EAGAIN) {
             dsh->status = DPIP_EAGAIN;
-            ret = -1;
             break;
          } else {
             MSG_ERR("[Dpip_dsh_read] %s\n", dStrerror(errno));
diff --git a/dw/fltkui.cc b/dw/fltkui.cc
index 1f0422b2..43a0d869 100644
--- a/dw/fltkui.cc
+++ b/dw/fltkui.cc
@@ -1126,7 +1126,7 @@ void *FltkListResource::newItem (const char *str, bool enabled, bool selected)
 
    enabled &= parent->is_active();
    item->activate(enabled);
-   item->user_data((void *)index);
+   item->user_data((void*)(long)index);
    itemsSelected.increase ();
    itemsSelected.set (itemsSelected.size() - 1, selected);
 
diff --git a/dw/style.cc b/dw/style.cc
index 7020503e..c8cab24f 100644
--- a/dw/style.cc
+++ b/dw/style.cc
@@ -815,8 +815,7 @@ void drawBorder (View *view, Rectangle *area,
                  Style *style, bool inverse)
 {
    /** \todo a lot! */
-   Color::Shading dark, light, normal;
-   int xb1, yb1, xb2, yb2, xp1, yp1, xp2, yp2;
+   int xb1, yb1, xb2, yb2;
 
    // top left and bottom right point of outer border boundary
    xb1 = x + style->margin.left;
@@ -824,15 +823,17 @@ void drawBorder (View *view, Rectangle *area,
    xb2 = x + (width > 0 ? width - 1 : 0) - style->margin.right;
    yb2 = y + (height > 0 ? height - 1 : 0) - style->margin.bottom;
 
-   // top left and bottom right point of inner border boundary
-   xp1 = xb1 + style->borderWidth.left;
-   yp1 = yb1 + style->borderWidth.top;
-   xp2 = xb2 - style->borderWidth.right;
-   yp2 = yb2 - style->borderWidth.bottom;
-
-   light = inverse ? Color::SHADING_DARK : Color::SHADING_LIGHT;
-   dark = inverse ? Color::SHADING_LIGHT : Color::SHADING_DARK;
-   normal = inverse ? Color::SHADING_INVERSE : Color::SHADING_NORMAL;
+   /*
+      // top left and bottom right point of inner border boundary
+      xp1 = xb1 + style->borderWidth.left;
+      yp1 = yb1 + style->borderWidth.top;
+      xp2 = xb2 - style->borderWidth.right;
+      yp2 = yb2 - style->borderWidth.bottom;
+   
+      light = inverse ? Color::SHADING_DARK : Color::SHADING_LIGHT;
+      dark = inverse ? Color::SHADING_LIGHT : Color::SHADING_DARK;
+      normal = inverse ? Color::SHADING_INVERSE : Color::SHADING_NORMAL;
+   */
 
    drawBorderRight(view, style, xb2, yb1, xb2, yb2);
    drawBorderLeft(view, style, xb1, yb1, xb1, yb2);
diff --git a/src/cssparser.cc b/src/cssparser.cc
index f173f403..3d62b31d 100644
--- a/src/cssparser.cc
+++ b/src/cssparser.cc
@@ -1049,7 +1049,7 @@ void CssParser::parseDeclaration(CssPropertyList * props,
                                  CssPropertyList * importantProps)
 {
    CssPropertyInfo pi = {NULL, {CSS_TYPE_UNUSED}, NULL}, *pip;
-   CssShorthandInfo si, *sip;
+   CssShorthandInfo *sip;
    CssValueType type = CSS_TYPE_UNUSED;
 
    CssPropertyName prop;
@@ -1087,7 +1087,6 @@ void CssParser::parseDeclaration(CssPropertyList * props,
          }
       } else {
          /* Try shorthands. */
-         si.symbol = tval;
          sip =
              (CssShorthandInfo *) bsearch(&pi, Css_shorthand_info,
                                           CSS_SHORTHAND_NUM,
diff --git a/src/html.cc b/src/html.cc
index 264e0041..1bdbd8fb 100644
--- a/src/html.cc
+++ b/src/html.cc
@@ -1718,7 +1718,6 @@ static void Html_tag_close_style(DilloHtml *html, int TagIdx)
 static void Html_tag_open_body(DilloHtml *html, const char *tag, int tagsize)
 {
    const char *attrbuf;
-   Textblock *textblock;
    int32_t color;
    int tag_index_a = a_Html_tag_index ("a");
    style::Color *bgColor;
@@ -1736,8 +1735,6 @@ static void Html_tag_open_body(DilloHtml *html, const char *tag, int tagsize)
       BUG_MSG("unclosed HEAD element\n");
    }
 
-   textblock = HT2TB(html);
-
    if ((attrbuf = a_Html_get_attr(html, tag, tagsize, "bgcolor"))) {
       color = a_Html_color_parse(html, attrbuf, -1);
       if (color != -1)
@@ -2165,7 +2162,6 @@ static void Html_tag_open_img(DilloHtml *html, const char *tag, int tagsize)
 {
    DilloImage *Image;
    DilloUrl *url, *usemap_url;
-   Textblock *textblock;
    const char *attrbuf;
 
    /* This avoids loading images. Useful for viewing suspicious HTML email. */
@@ -2176,8 +2172,6 @@ static void Html_tag_open_img(DilloHtml *html, const char *tag, int tagsize)
        !(url = a_Html_url_new(html, attrbuf, NULL, 0)))
       return;
 
-   textblock = HT2TB(html);
-
    usemap_url = NULL;
    if ((attrbuf = a_Html_get_attr(html, tag, tagsize, "usemap")))
       /* TODO: usemap URLs outside of the document are not used. */
@@ -2254,12 +2248,11 @@ static void Html_tag_close_map(DilloHtml *html, int TagIdx)
 static
 misc::SimpleVector<int> *Html_read_coords(DilloHtml *html, const char *str)
 {
-   int i, coord;
+   int coord;
    const char *tail = str;
    char *newtail = NULL;
    misc::SimpleVector<int> *coords = new misc::SimpleVector<int> (4);
 
-   i = 0;
    while (1) {
       coord = strtol(tail, &newtail, 10);
       if (coord == 0 && newtail == tail)
@@ -2959,14 +2952,13 @@ void a_Html_load_stylesheet(DilloHtml *html, DilloUrl *url)
 
             if (endq && (endq - data <= 51)) {
                /* IANA limits charset names to 40 characters */
-               const char *ignored;
                char *content_type;
 
                *endq = '\0';
                content_type = dStrconcat("text/css; charset=", data+10, NULL);
                *endq = '"';
                a_Capi_unref_buf(url);
-               ignored = a_Capi_set_content_type(url, content_type, "meta");
+               a_Capi_set_content_type(url, content_type, "meta");
                dFree(content_type);
                a_Capi_get_buf(url, &data, &len);
             }
diff --git a/src/nav.c b/src/nav.c
index 7f9d03db..f7aa26c9 100644
--- a/src/nav.c
+++ b/src/nav.c
@@ -195,13 +195,12 @@ static void Nav_open_url(BrowserWindow *bw, const DilloUrl *url,
                          const DilloUrl *requester, int offset)
 {
    const DilloUrl *old_url;
-   bool_t MustLoad, ForceReload, Repush, IgnoreScroll;
+   bool_t MustLoad, ForceReload, IgnoreScroll;
    int x, y, idx, ClientKey;
    DilloWeb *Web;
 
    MSG("Nav_open_url: new url='%s'\n", URL_STR_(url));
 
-   Repush = (URL_FLAGS(url) & URL_ReloadFromCache) != 0;
    ForceReload = (URL_FLAGS(url) & (URL_E2EQuery + URL_ReloadFromCache)) != 0;
    IgnoreScroll = (URL_FLAGS(url) & URL_IgnoreScroll) != 0;
 
diff --git a/src/table.cc b/src/table.cc
index 58cdf22e..d48a0c45 100644
--- a/src/table.cc
+++ b/src/table.cc
@@ -151,7 +151,6 @@ void Html_tag_open_tr(DilloHtml *html, const char *tag, int tagsize)
 {
    const char *attrbuf;
    int32_t bgcolor = -1;
-   bool new_style = false;
 
    html->styleEngine->inheritNonCssHints ();
 
@@ -183,10 +182,8 @@ void Html_tag_open_tr(DilloHtml *html, const char *tag, int tagsize)
       if (bgcolor != -1) {
          html->styleEngine->setNonCssHint(CSS_PROPERTY_BACKGROUND_COLOR,
                                           CSS_TYPE_COLOR, bgcolor);
-         new_style = true;
       }
-      if (a_Html_tag_set_valign_attr (html, tag, tagsize))
-         new_style = true;
+      a_Html_tag_set_valign_attr (html, tag, tagsize);
       break;
    default:
       break;
@@ -318,7 +315,6 @@ static void Html_tag_open_table_cell(DilloHtml *html,
    int colspan = 1, rowspan = 1;
    const char *attrbuf;
    int32_t bgcolor;
-   bool_t new_style;
 
    html->styleEngine->inheritNonCssHints ();
 
@@ -363,8 +359,7 @@ static void Html_tag_open_table_cell(DilloHtml *html,
                                            a_Html_parse_length (html, attrbuf));
       }
 
-      if (a_Html_tag_set_valign_attr (html, tag, tagsize))
-         new_style = TRUE;
+      a_Html_tag_set_valign_attr (html, tag, tagsize);
 
       if ((attrbuf = a_Html_get_attr(html, tag, tagsize, "bgcolor"))) {
          bgcolor = a_Html_color_parse(html, attrbuf, -1);
diff --git a/src/ui.cc b/src/ui.cc
index 1731f469..c50282d3 100644
--- a/src/ui.cc
+++ b/src/ui.cc
@@ -425,7 +425,7 @@ Fl_Button *UI::make_button(const char *label, Fl_Image *img, Fl_Image *deimg,
       b->image(img);
    if (deimg)
       b->deimage(deimg);
-   b->callback(b1_cb, (void *)b_n);
+   b->callback(b1_cb, INT2VOIDP(b_n));
    b->clear_visible_focus();
    b->labelsize(12);
    b->box(FL_FLAT_BOX);
diff --git a/test/dw_anchors_test.cc b/test/dw_anchors_test.cc
index e5fcdbf2..10525f1a 100644
--- a/test/dw_anchors_test.cc
+++ b/test/dw_anchors_test.cc
@@ -112,7 +112,7 @@ int main(int argc, char **argv)
       buf[0] = toupper (buf[0]);
       buttonLabel[i] = strdup(buf);
       Fl_Button *button = new Fl_Button(0, 20 * i, 50, 20, buttonLabel[i]);
-      button->callback (anchorCallback, (void*)i);
+      button->callback (anchorCallback, (void*)(long)i);
       button->when (FL_WHEN_RELEASE);
    }